Category Archives: Code review practices

What to Look for in Java 8 Code

In earlier blog posts we’ve talked about general things to look for during a code review. Recently I’ve been working a lot with Java 8, and I’m starting to have some opinions on what modern Java code should look like. … Continue reading

Posted in Code review practices | Tagged | 7 Comments

Code review workflows

Code review workflows are as diverse as teams that use them. Some teams are flexible and review only certain commits as they see fit, others have more formal criteria of what should be reviewed, by whom, and how the outcome … Continue reading

Posted in Code review practices, Feature | Leave a comment

“What to Look for in a Code Review” book

Last year we published a series of blog posts written by talented Trisha Gee attempting to answer questions like: What should we look for in a code review? What kind of questions we should ask ourselves as reviewers? What kind … Continue reading

Posted in Code review practices | Leave a comment

What to look for in a Code Review: Upsource Quick Wins

We’ve had two themes running through the articles on what to look for in a code review: Lots of what we’re tempted to look for can (and should) be automated Humans are good at checking things computers can not. In … Continue reading

Posted in Code review practices | 3 Comments

What to look for in a Code Review: Security

This is part 6 of 6 posts on what to look for in a code review. See previous posts from the series. How much work you do building a secure, robust system is like anything else on your project – it … Continue reading

Posted in Code review practices | Leave a comment

What to look for in a Code Review: SOLID Principles

This is part 5 of 6 posts on what to look for in a code review. See other posts from the series. In today’s post we’ll look more closely at the design of the code itself, specifically checking to see if … Continue reading

Posted in Code review practices | 4 Comments

What to look for in a Code Review: Data Structures

This is part 4 of 6 posts on what to look for in a code review. See previous posts from the series. Data structures are a fundamental part of programming – so much so it’s actually one of the areas that’s consistently … Continue reading

Posted in Code review practices | 8 Comments

What to look for in a Code Review: Performance

This is part 3 of 6 posts on what to look for in a code review. See other posts from the series. In part three of our series on code reviews, we’re going to cover what you can look for in … Continue reading

Posted in Code review practices | 2 Comments

What to look for in a Code Review: Tests

This is part 2 of 6 posts on what to look for in a code review. See other posts from the series. In the last post we talked about a wide variety of things you could look for in a code review. … Continue reading

Posted in Code review practices | Leave a comment

What to look for in a Code Review

This is part 1 of 6 posts on what to look for in a code review. See other posts from the series. Let’s talk about code reviews. If you take only a few seconds to search for information about code reviews, … Continue reading

Posted in Code review practices | 14 Comments