Category Archives: Code review practices

Automating Your Code Review Workflow with Upsource

The last three posts on code review workflows show that there’s more than one way to do a code review, and that the approach you take will depend upon what you want to achieve with your reviews and the type … Continue reading

Posted in Code review practices, Newsletter | Tagged | Leave a comment

Code Review for Knowledge Sharing

In the last two posts we talked a bit about how effective those approaches are for the author to learn and improve, because those two approaches focus on getting the code correct. The Design Evolution approach additionally mentions the value … Continue reading

Posted in Code review practices, Newsletter | Tagged | Leave a comment

Code Review for Design Evolution

In the last post we covered a review process where the code review is performed after all the code is written with the goal of approving the suggested changes. If getting the design right is important to your team, then a … Continue reading

Posted in Code review practices, Newsletter | Tagged , , | 4 Comments

Code Review As A Gateway

We’ve talked a lot about what to look for in a Code Review, but we haven’t covered the process at all. There are many different reasons to perform code reviews in your team or organisation, and the process you choose should … Continue reading

Posted in Code review practices, Newsletter | Tagged , , | 4 Comments

What to Look for in Java 8 Code

In earlier blog posts we’ve talked about general things to look for during a code review. Recently I’ve been working a lot with Java 8, and I’m starting to have some opinions on what modern Java code should look like. … Continue reading

Posted in Code review practices | Tagged | 7 Comments

Code review workflows

Code review workflows are as diverse as teams that use them. Some teams are flexible and review only certain commits as they see fit, others have more formal criteria of what should be reviewed, by whom, and how the outcome … Continue reading

Posted in Code review practices, Feature | Leave a comment

“What to Look for in a Code Review” book

Last year we published a series of blog posts written by talented Trisha Gee attempting to answer questions like: What should we look for in a code review? What kind of questions we should ask ourselves as reviewers? What kind … Continue reading

Posted in Code review practices | Leave a comment

What to look for in a Code Review: Upsource Quick Wins

We’ve had two themes running through the articles on what to look for in a code review: Lots of what we’re tempted to look for can (and should) be automated Humans are good at checking things computers can not. In … Continue reading

Posted in Code review practices | 3 Comments

What to look for in a Code Review: Security

This is part 6 of 6 posts on what to look for in a code review. See previous posts from the series. How much work you do building a secure, robust system is like anything else on your project – it … Continue reading

Posted in Code review practices | Leave a comment

What to look for in a Code Review: SOLID Principles

This is part 5 of 6 posts on what to look for in a code review. See other posts from the series. In today’s post we’ll look more closely at the design of the code itself, specifically checking to see if … Continue reading

Posted in Code review practices | 5 Comments