Malicious code reviews: 11 tips to piss the whole team off
Disclaimer: Please do not take this post seriously, and happy Friday!
Your team has decided to adopt code review practice, and your perfect code now will be judged by someone else. Well, how dare they think they can find any issues with your brilliant code? On top of that, you need to spend your valuable time reviewing someone else’s code? That does it! Fight back the tyranny by following these simple rules:
If your code is about to be reviewed
- Commit all the features and bug-fixes you’ve worked on this week in one go, and ask for a review. Let them see how much work you’ve done.
- Invite the whole team to review your code. Everybody has to know how great your features are.
- Be original. Do not use spell checker, do not use static code analysis. Do, however, use ReSharper or IntelliJ IDEA to reformat code to your style, ignoring the company’s standards.
- Introduce a tricky bug on purpose. See if they’re smart enough to find it.
- Take your time. Got a code review assigned to you? Take your time, it’s not important. No, really, have a cup of tea, answer all unanswered emails, tweet something, see what you friends have been up to on facebook, go home. Why should reading someone’s code be more important than what you want to do? Feel free to ignore notifications for a week or two: you are busy.
- Take your time doing review. They wanted you to find issues? Don’t close the review until you find at least a dozen, even if it takes months.
- See a bug? Perfect! First, question the author’s intelligence, then, when your superiority is well established, demand a fix.
- Found an elegant solution to a problem? Don’t tell anyone, especially the code author, that you’re impressed. Keep it cool, act like you’ve always knew how to do things best.
- Embrace your inner grammar nazi: Focus on the spelling, it’s the most important thing! How can we misspell things and call ourselves professionals?
- Count all the spaces. Point out every bad indentation.
- Never compromise. Even if another solution offered by your teammate is better than yours. Stand your ground.
If you are reviewing someone else’s code
As of February 1, 2022, we will no longer sell new licenses or renewals for Upsource or Upsource user packs. We will continue to provide technical support and critical security updates until January 31, 2023. After this, no further updates or technical support will be provided. Why we are dis…
What’s New in Upsource 2020.1
This release introduces a variety of improvements related to GitHub and GitLab synchronization as well as some other features. Please read the release highlights for details. (more…)…
Upsource 2019.1.1460 is available!
Upsource 2019.1.1460 is out! Upsource 2019.1 was failing to start on some Linux systems. In this update, we have fixed this critical issue and made some other improvements. We recommend everyone to update to this latest build. Check out the release notes and download the new build. If you hav…
What’s New in Upsource 2019.1
Great news everyone – Upsource 2019.1 is out! We have added a number of features and improved the performance to smooth out your code review process. It also comes bundled with IntelliJ IDEA 2019.1 and Hub 2018.4, and supports servers running Mercurial 4.9 and newer. For more details, read the re…